Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-specification submodule to include the 1.18.0 schema. #2301

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

carlosalberto
Copy link
Contributor

@carlosalberto carlosalberto commented Feb 8, 2023

@carlosalberto carlosalberto requested a review from a team as a code owner February 8, 2023 00:32
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an invalid hash in one of the links:

7:33:29 PM: blog/2022/exponential-histograms/index.html
7:33:29 PM:   hash does not exist --- blog/2022/exponential-histograms/index.html --> /docs/reference/specification/metrics/sdk/#exponential-bucket-histogram-aggregation
7:33:29 PM: ========================================================================
7:33:29 PM: ✘✘✘ failed in 2.47021589s
7:33:29 PM: 1 errors in 328 documents

Do you want me to look into fixing this @carlosalberto or are you already on it?

@chalin chalin requested a review from a team as a code owner February 8, 2023 01:07
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link fixed! LGTM

@chalin chalin merged commit bfd42b5 into open-telemetry:main Feb 8, 2023
@carlosalberto carlosalberto deleted the spec-schema-1-18-0 branch February 8, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants