Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo docs: fix architecture diagram layout #2318

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Demo docs: fix architecture diagram layout #2318

merged 1 commit into from
Feb 10, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 10, 2023

Screenshots

Before

image

After

image

From original demo repo docs (GitHub preview)

image

@chalin chalin added design/style Front-end site design / styling demo labels Feb 10, 2023
@chalin chalin requested a review from a team February 10, 2023 01:15
@chalin chalin requested a review from a team as a code owner February 10, 2023 01:15
@chalin
Copy link
Contributor Author

chalin commented Feb 10, 2023

Thanks for the review and approval @reyang!

@mviitane - let me know what your answer is to the question in the opening comment. I'll follow through based on what you respond. Thx!

@chalin chalin merged commit ef24e14 into open-telemetry:main Feb 10, 2023
@chalin chalin deleted the chalin-im-demo-arch-pic-fix-2023-02-09 branch February 10, 2023 01:23
This was referenced Feb 10, 2023
Closed
Merged
Closed
@mviitane
Copy link
Member

@mviitane - let me know what your answer is to the question in the opening comment. I'll follow through based on what you respond. Thx!

Yes, the main problem is solved now! Thank you!

@chalin chalin mentioned this pull request Feb 17, 2023
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
demo design/style Front-end site design / styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo docs: Architecture picture fit
3 participants
@chalin @mviitane @reyang