Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to the active item when the navbar is too long #2340

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Scroll to the active item when the navbar is too long #2340

merged 5 commits into from
Mar 24, 2023

Conversation

rogerogers
Copy link
Contributor

Scroll to the active item when the navbar is too long

@rogerogers rogerogers requested a review from a team as a code owner February 15, 2023 13:05
chalin
chalin reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Can you provide details (e.g., screenshots) of the problem this PR is trying to solve?

@rogerogers
Copy link
Contributor Author

image
When clicking deep-level nav eg Webengine, the active nav item disappears, this pr scrolls it into view.
image

@rogerogers
Copy link
Contributor Author

@chalin PTAL Webengine

@chalin
Copy link
Contributor

chalin commented Feb 20, 2023

Hi @rogerogers. Thanks for providing context and an example link. I'll get to this as soon as I can.

@rogerogers @chalin
Scroll to the active item when the navbar is too long
f896578 
Signed-off-by: rogerogers <rogers@rogerogers.com>
@chalin
Copy link
Contributor

chalin commented Mar 17, 2023

/fix:format

svrnm
svrnm approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @chalin merge this based on your judgment (and availability)

cc @cartermp

cartermp
cartermp approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's also merge and we can adjust later if it can be improved. It works!

@cartermp cartermp merged commit cef971b into open-telemetry:main Mar 24, 2023
Arhell pushed a commit to Arhell/opentelemetry.io that referenced this pull request Mar 24, 2023
@rogerogers @chalin
@cartermp @Arhell
Scroll to the active item when the navbar is too long (open-telemetry…
a9d0872 
…#2340)

Co-authored-by: chalin <chalin@users.noreply.github.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@rogerogers rogerogers deleted the chore/nav branch March 25, 2023 01:37
@rogerogers rogerogers mentioned this pull request Mar 25, 2023
Merged
@chalin chalin mentioned this pull request Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@svrnm svrnm svrnm approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rogerogers @chalin @svrnm @cartermp