Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding PHP documentation for exporters, resources, propagation #2415

Merged
merged 28 commits into from
Mar 1, 2023
Merged

adding PHP documentation for exporters, resources, propagation #2415

merged 28 commits into from
Mar 1, 2023

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Feb 28, 2023 •
edited by chalin

@brettmc brettmc requested review from a team as code owners February 28, 2023 02:48
@brettmc brettmc mentioned this pull request Feb 28, 2023
Closed
cartermp
cartermp reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great content overall. Did an editing pass.

content/en/docs/instrumentation/php/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/propagation.md Show resolved Hide resolved
content/en/docs/instrumentation/php/propagation.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/resources.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/resources.md Outdated Show resolved Hide resolved
svrnm
svrnm requested changes Feb 28, 2023
View reviewed changes
content/en/docs/instrumentation/php/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/manual.md Outdated Show resolved Hide resolved
chalin
chalin reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. See inline comments.

content/en/docs/instrumentation/php/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/propagation.md Outdated
---
title: Propagation
description: Context propagation for the PHP API
aliases: [/docs/instrumentation/php/api/propagation]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the alias.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You dropped too many aliases. This one (in the new file) needed to be removed, not the one in content/en/docs/instrumentation/php/getting-started.md. Restore that alias.

content/en/docs/instrumentation/php/propagation.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/propagation.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/propagation.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/resources.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/resources.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/exporters.md Outdated Show resolved Hide resolved
@brettmc
Copy link
Contributor Author

brettmc commented Feb 28, 2023

I think I've addressed all feedback now.

chalin
chalin approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One alias that needs to be recovered (was deleted by mistake). Otherwise LGTM, but I'll let @cartermp and @svrnm have the final word about content.

cartermp
cartermp approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great docs!

@svrnm
Copy link
Member

svrnm commented Mar 1, 2023

@brettmc can you fix the last open issue from @chalin , then we should be able to merge this.

brettmc and others added 17 commits March 1, 2023 07:20
@brettmc @chalin
adding PHP documentation for exporters, resources, propagation
b43a92f
@brettmc @chalin
run prettier
71c384b
@brettmc @chalin
fixing markup
4a84c6b
@brettmc @chalin
fixing build failures
94b6a06
@brettmc @chalin
linting
8726e04
@brettmc @chalin
proof reading
12c7d94
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/exporters.md
cb7bff8 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/exporters.md
12137bc 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/exporters.md
3fd6d62 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/exporters.md
a7e4054 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/exporters.md
956a5c9 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/exporters.md
9f6b336 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/propagation.md
5fa13d3 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/propagation.md
43f3000 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @cartermp @chalin
Update content/en/docs/instrumentation/php/resources.md
c6db5b0 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@brettmc @chalin
review feedback
6f8650f
@brettmc @chalin
fixing zipkin example formatting
660a8ff
@chalin
Copy link
Contributor

chalin commented Mar 1, 2023

@brettmc can you fix the last open issue from @chalin , then we should be able to merge this.

The alias was added back, so we're good to go! Merging ...

@chalin chalin merged commit 100e517 into open-telemetry:main Mar 1, 2023
@chalin chalin mentioned this pull request Mar 1, 2023
Open
@brettmc brettmc deleted the php-docs branch June 21, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@svrnm svrnm svrnm approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brettmc @svrnm @chalin @cartermp