Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo] Add C++ metrics #2432

Merged
merged 4 commits into from
Mar 2, 2023
Merged

[demo] Add C++ metrics #2432

merged 4 commits into from
Mar 2, 2023

Conversation

julianocosta89
Copy link
Member

Fix #2403

Added documentation about C++ metrics, which was introduced to the demo in this PR: open-telemetry/opentelemetry-demo#759

@julianocosta89 julianocosta89 requested review from a team as code owners March 1, 2023 16:02
cartermp
cartermp approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just needs a prettier run.

chalin
chalin reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, thanks.

content/en/docs/demo/services/currency.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/currency.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/currency.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/currency.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/currency.md Outdated Show resolved Hide resolved
julianocosta89 and others added 3 commits March 2, 2023 07:18
@julianocosta89 @chalin
Apply suggestions from code review
e6a33d0 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Prettier
c70a4bc
prettier
673d4aa
@svrnm svrnm merged commit 4547ad2 into open-telemetry:main Mar 2, 2023
@julianocosta89 julianocosta89 deleted the demo-add-metrics-to-cpp branch March 2, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@svrnm svrnm svrnm approved these changes

@cartermp cartermp cartermp approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo Documentation - Update Currency Service Metrics
5 participants
@julianocosta89 @svrnm @chalin @cartermp @fatsheep9146