Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registry scanner and include two more entries #2433

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Fix registry scanner and include two more entries #2433

merged 2 commits into from
Mar 3, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Mar 1, 2023

Fixes the registry scanner to work with the YML files.

@svrnm
Fix registry scanner
3518209 
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team as a code owner March 1, 2023 16:38
chalin
chalin reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried it, but LGTM :)

Consider updating the PR title to say that it also contains two new entries.

@cartermp cartermp changed the title Fix registry scanner Fix registry scanner and include two more entries Mar 3, 2023
@cartermp cartermp merged commit ab1e78b into open-telemetry:main Mar 3, 2023
@svrnm svrnm deleted the fix-registry-scanner branch May 11, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svrnm @chalin @cartermp