-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concept page about sampling #2434
Conversation
RE: the images -- should I redo this and put it in a directory so I can also store images for this page, or does it make sense to create an |
@reese-lee - for images that appear exclusively in a page, create a page bundle like this:
I hope that helps. If you'd prefer that I set that up for you, just add the images at the same level as the |
Thank you! I went ahead and did the things. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good. There's a lot I'd like to elaborate on for the topic, but it's far better to get this into the docs now than to stress over several more paragraphs of sampling techniques and tradeoffs.
@reese-lee if you run the prettier formatter over your changes then this will be good to merge. |
…ts/sampling/index.md
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
90d1471
to
b1cc299
Compare
I rebased, ran the formatter, added a weight (so that the sampling page shows up just before the SDK page) and compressed images. PTAL @reese-lee @cartermp: |
This takes the first two sections of my tail sampling blog post to start this doc, per this issue #2423.