Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concept page about sampling #2434

Merged
merged 9 commits into from
Mar 3, 2023
Merged

Add concept page about sampling #2434

merged 9 commits into from
Mar 3, 2023

Conversation

reese-lee
Copy link
Member

@reese-lee reese-lee commented Mar 1, 2023

This takes the first two sections of my tail sampling blog post to start this doc, per this issue #2423.

@reese-lee reese-lee requested a review from a team as a code owner March 1, 2023 22:44
@reese-lee
Copy link
Member Author

RE: the images -- should I redo this and put it in a directory so I can also store images for this page, or does it make sense to create an img directory in the root of the Concepts directory for all images used in this section?

@chalin
Copy link
Contributor

chalin commented Mar 1, 2023

@reese-lee - for images that appear exclusively in a page, create a page bundle like this:

  • Create a directory sample and in it place:
    • The page content inside index.md
    • The various images (directly, not inside an img folder)

I hope that helps. If you'd prefer that I set that up for you, just add the images at the same level as the .md and I'll make relocate & rename files before merging. Let me know.

@reese-lee
Copy link
Member Author

Thank you! I went ahead and did the things. :)

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks good. There's a lot I'd like to elaborate on for the topic, but it's far better to get this into the docs now than to stress over several more paragraphs of sampling techniques and tradeoffs.

content/en/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/en/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/en/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor

cartermp commented Mar 3, 2023

@reese-lee if you run the prettier formatter over your changes then this will be good to merge.

@chalin
Copy link
Contributor

chalin commented Mar 3, 2023

I rebased, ran the formatter, added a weight (so that the sampling page shows up just before the SDK page) and compressed images. PTAL @reese-lee @cartermp:

@cartermp cartermp merged commit de60a8e into main Mar 3, 2023
@cartermp cartermp deleted the reese-lee-patch-1 branch March 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants