Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel-in-focus: link core components to website section #2444

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 3, 2023

What you think about linking core components to their website landing pages -- @austinlparker @svrnm @cartermp? This makes it easier for readers to find out more about the component.

Screenshot

Here's a screenshot of what it could look like:

image

Before

In contrast, this is what is was before this PR:

image

Note that I moved the PHP news into the Releases and Updates section.

@chalin chalin requested review from a team as code owners March 3, 2023 11:34
@chalin
Copy link
Contributor Author

chalin commented Mar 3, 2023

Btw, unfortunately, Prettier doesn't handle definitions lists yet, which is why I added the ignore directives. For details, see:

@chalin chalin force-pushed the chalin-im-otel-in-focus-2023-03-03 branch from c9eff10 to f564ded Compare March 3, 2023 15:43
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the adjustment

@svrnm
Copy link
Member

svrnm commented Mar 4, 2023

lgtm

@svrnm svrnm merged commit cad59c2 into open-telemetry:main Mar 4, 2023
@chalin chalin deleted the chalin-im-otel-in-focus-2023-03-03 branch March 4, 2023 12:43
@chalin
Copy link
Contributor Author

chalin commented Mar 4, 2023

Thanks for the reviews. FYI, I'll follow up with some styling fixes (so that the page doesn't contain an embedded <style> element).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants