Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel end user discussions february 2023 #2456

Conversation

ankit01-oss
Copy link
Contributor

@ankit01-oss ankit01-oss commented Mar 7, 2023

ankit01-oss and others added 29 commits February 28, 2023 15:42
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
@ankit01-oss ankit01-oss requested a review from a team as a code owner March 7, 2023 07:49
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fresh PR, we're getting close!
I've adjusted the date and made a few more copyedits.

content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
ankit01-oss and others added 7 commits March 7, 2023 19:10
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@ankit01-oss
Copy link
Contributor Author

Thanks @chalin for the edits. I have committed the suggestions.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Oops, forgot one change -- see inline comment. Otherwise, LGTM ✨

content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
ankit01-oss and others added 2 commits March 7, 2023 19:40
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cartermp cartermp merged commit c390db5 into open-telemetry:main Mar 7, 2023
@chalin
Copy link
Contributor

chalin commented Mar 7, 2023

Woohoo! Thanks @ankit01-oss et al!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants