Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order node.js over browser for TOC #2469

Merged

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Mar 8, 2023

Node is hit a lot more in our docs. From my own work, I can also say that teams using node are ~4.5x more numerous than teams sending instrumentation from the browser. So let's have the TOC reflect that.

image

@cartermp cartermp requested review from a team as code owners March 8, 2023 21:02
@chalin chalin force-pushed the cartermp/node-browser-reorder branch from 3088b89 to 919aa64 Compare March 8, 2023 21:15
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it might be a good idea to multiply the weights by 10, to give us some room (though this section might not have new pages). As is, is ok too.

@cartermp
Copy link
Contributor Author

cartermp commented Mar 8, 2023

Yeah, I doubt there'd be more in this subfolder, but it's easy enough to tweak later.

@cartermp cartermp merged commit 4aaf1f5 into open-telemetry:main Mar 8, 2023
@cartermp cartermp deleted the cartermp/node-browser-reorder branch March 8, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants