Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampling doc for JS #2482

Merged
merged 10 commits into from
Mar 13, 2023
Merged

Add sampling doc for JS #2482

merged 10 commits into from
Mar 13, 2023

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Mar 11, 2023

@cartermp cartermp requested review from a team as code owners March 11, 2023 17:08
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@svrnm
Copy link
Member

svrnm commented Mar 13, 2023

nice! @cartermp on fire:-)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for documenting this. 🙂
I have two suggestions. 🙂

content/en/docs/instrumentation/js/sampling.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/sampling.md Outdated Show resolved Hide resolved
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 🚀

@cartermp cartermp merged commit 23b6d15 into main Mar 13, 2023
@cartermp cartermp deleted the cartermp/js-sampler branch March 13, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants