Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update discussion-group.md #2501

Merged
merged 7 commits into from
Mar 14, 2023
Merged

Update discussion-group.md #2501

merged 7 commits into from
Mar 14, 2023

Conversation

reese-lee
Copy link
Member

@reese-lee reese-lee commented Mar 13, 2023 •
edited by chalin

This PR includes:

  • New dates for the sessions through May
  • Info about how to find summaries of past discussions on the OTel blog
  • Luma link for APAC sessions

Preview: https://deploy-preview-2501--opentelemetry.netlify.app/community/end-user/discussion-group/

@reese-lee reese-lee requested a review from a team as a code owner March 13, 2023 22:22
@reese-lee reese-lee requested a review from a team March 13, 2023 22:22
musingvirtual
musingvirtual approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@musingvirtual musingvirtual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cartermp
cartermp approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, if you run npm run test it should update the formatting refcache

@reese-lee
Copy link
Member Author

Hm so I ran npm run-script prettier:write and it looks like it did the thing?

Screen Shot 2023-03-13 at 6 01 11 PM

@chalin
Copy link
Contributor

chalin commented Mar 14, 2023

Hm so I ran npm run-script prettier:write and it looks like it did the thing?

Good. Now you need to commit the changed (i.e., reformatted) files.

@reese-lee
Copy link
Member Author

Ah, right. Ok, done!

chalin
chalin approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@chalin chalin merged commit 5ba8ae2 into main Mar 14, 2023
@chalin chalin deleted the reese-lee-patch-1 branch March 14, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musingvirtual musingvirtual musingvirtual approved these changes

@chalin chalin chalin approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reese-lee @chalin @musingvirtual @cartermp