Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry PHP Auto-Instrumentation blog post #2506

Merged
merged 36 commits into from
Mar 21, 2023
Merged

OpenTelemetry PHP Auto-Instrumentation blog post #2506

merged 36 commits into from
Mar 21, 2023

Conversation

pdelewski
Copy link
Member

No description provided.

@pdelewski pdelewski requested review from a team as code owners March 14, 2023 16:44
@pdelewski pdelewski force-pushed the php-autoinstrumentation-blogpost branch 5 times, most recently from 053ab2b to dcc1d52 Compare March 14, 2023 17:19
@pdelewski pdelewski requested a review from a team March 14, 2023 17:26
@pdelewski pdelewski force-pushed the php-autoinstrumentation-blogpost branch from dcc1d52 to c3d0dfe Compare March 14, 2023 17:29
brettmc
brettmc requested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I've suggested some small changes for readability etc :)

content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
@pdelewski pdelewski force-pushed the php-autoinstrumentation-blogpost branch from eeb3d67 to 990c164 Compare March 15, 2023 08:10
@pdelewski
Copy link
Member Author

@brettmc Thank you for the review. I applied your suggestions

svrnm
svrnm requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great read, a few suggestions.

content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Show resolved Hide resolved
@pdelewski
Copy link
Member Author

@svrnm Thank you for suggestions. Applied changes

@pdelewski pdelewski force-pushed the php-autoinstrumentation-blogpost branch from bdc341e to b529e1f Compare March 15, 2023 12:26
@svrnm
Copy link
Member

svrnm commented Mar 15, 2023

Preview: https://deploy-preview-2506--opentelemetry.netlify.app/blog/2023/php-auto-instrumentation/

chalin
chalin requested changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments. The docsy change must be resolved (dropped) before this lands.

themes/docsy Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
Przemek Delewski and others added 8 commits March 15, 2023 16:18
OpenTelemetry PHP Auto-Instrumentation blog post
e6f10c1
@pdelewski @brettmc
Update content/en/blog/2023/php-auto-instrumentation/index.md
aaa2bfb 
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
@pdelewski @brettmc
Update content/en/blog/2023/php-auto-instrumentation/index.md
54fe915 
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
@pdelewski @brettmc
Update content/en/blog/2023/php-auto-instrumentation/index.md
a1d18fe 
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
@pdelewski @brettmc
Update content/en/blog/2023/php-auto-instrumentation/index.md
6f9bac2 
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
@pdelewski @brettmc
Update content/en/blog/2023/php-auto-instrumentation/index.md
caec69b 
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
@pdelewski @brettmc
Update content/en/blog/2023/php-auto-instrumentation/index.md
d2ab90c 
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
@pdelewski @brettmc
Update content/en/blog/2023/php-auto-instrumentation/index.md
09a5458 
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
chalin
chalin approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't read through in detail, will go with the feedback of @svrnm & others for that, but aside from a few code-block language issues (noted inline), LGTM.

@pdelewski pdelewski force-pushed the php-autoinstrumentation-blogpost branch from 02696a8 to 912b853 Compare March 15, 2023 17:16
@pdelewski pdelewski requested a review from brettmc March 16, 2023 15:30
cartermp
cartermp requested changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is really exciting. I love seeing this project come to life and it will be fantastic to announce it to the world.

Some minor suggested changes from my part. Basically, as the project stabilizes I'd like to find a way to bring it into the docs. Pulling content from the post here will save us time an energy, so if we change the post a little bit to be slightly more docs-like, we'll probably thank our past selves in the future.

content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
tcarrio
tcarrio reviewed Mar 19, 2023
View reviewed changes
Copy link

@tcarrio tcarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small touchups (if they're valid still, I see changes went through). Awesome blog post! I'll be reading into all of this more 😁

content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
@pdelewski @cartermp
Update content/en/blog/2023/php-auto-instrumentation/index.md
8085de9 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@pdelewski pdelewski requested a review from cartermp March 20, 2023 08:31
@pdelewski pdelewski force-pushed the php-autoinstrumentation-blogpost branch from cbb2697 to 1dc7bdc Compare March 20, 2023 08:35
cartermp
cartermp approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great updates.

brettmc
brettmc approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one typo found in my last proof-read.

content/en/blog/2023/php-auto-instrumentation/index.md Outdated Show resolved Hide resolved
@pdelewski
Copy link
Member Author

@open-telemetry/docs-maintainers Can we merge it?

@svrnm
Copy link
Member

svrnm commented Mar 21, 2023

@open-telemetry/docs-maintainers Can we merge it?

I still see a few open suggestions, can you quickly double check them and close them as resolved

@pdelewski
Copy link
Member Author

pdelewski commented Mar 21, 2023 •
edited

@svrnm Now should be ok. I resolved open suggestions and updated one small thing.

@svrnm svrnm merged commit 4615127 into open-telemetry:main Mar 21, 2023
@svrnm
Copy link
Member

svrnm commented Mar 21, 2023

https://opentelemetry.io/blog/2023/php-auto-instrumentation/ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@chalin chalin chalin approved these changes

@tcarrio tcarrio tcarrio left review comments

@brettmc brettmc brettmc approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pdelewski @svrnm @chalin @brettmc @cartermp @tcarrio