Auto-update java instrumentation version #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Apr 3, 2023
cartermp
approved these changes
Apr 3, 2023
trask
added a commit
to open-telemetry/opentelemetry-java-instrumentation
that referenced
this pull request
Apr 3, 2023
the auto-update will be triggered from the doc repo after open-telemetry/opentelemetry.io#2568
chalin
reviewed
May 7, 2023
Comment on lines
26
to
+27
| .github/workflows/scripts/auto-update-version.sh "opentelemetry-java" "javaVersion" "content/en/docs/instrumentation/java/_index.md" | ||
| .github/workflows/scripts/auto-update-version.sh "opentelemetry-java-instrumentation" "javaInstrumentationVersion" "content/en/docs/instrumentation/java/automatic/annotations.md" |
There was a problem hiding this comment.
@trask - just double checking: was it intentional to not do a hard reset between the Java and Java-instrumentation version-update commands? If both are updated, the second PR will have two file updates (the one from the first PR and the java-instrumentation update.
If it wasn't intentional, then here's a fix:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we'll turn off the auto-update that is triggered from the instrumentation repo after this is merged