Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java documentation for log signal #2583

Merged
merged 3 commits into from
Apr 22, 2023

Conversation

jack-berg
Copy link
Member

cc @open-telemetry/java-maintainers, @open-telemetry/java-instrumentation-maintainers

I excluded any docs about how logs work with the java agent, but that would be worth following up on. Essentially, the java agent automatically configures all the stuff I talk about in this PR.

@jack-berg jack-berg requested a review from a team as a code owner April 6, 2023 19:26
@jack-berg jack-berg requested a review from a team April 6, 2023 19:26
@jack-berg jack-berg requested a review from a team as a code owner April 6, 2023 19:26
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, but we'll want to address the TODOs here

@cartermp cartermp merged commit b1f26d2 into open-telemetry:main Apr 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants