Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also add format commands #2593

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Also add format commands #2593

merged 3 commits into from
Apr 13, 2023

Conversation

cartermp
Copy link
Contributor

Inspired by my recent misadventure of running:

npm run format
npm run format:write
npm run prettier:write

because I don't read instructions, I expect others won't, so here's an attempt to help things

@cartermp cartermp requested a review from a team as a code owner April 11, 2023 20:54
chalin
chalin approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the given suggestions

package.json Outdated Show resolved Hide resolved
cartermp and others added 2 commits April 13, 2023 08:38
@cartermp @chalin
Update package.json
e05019e 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartermp
Merge branch 'main' into cartermp/format-commands
8d2bf8f
@cartermp cartermp merged commit e251516 into main Apr 13, 2023
6 checks passed
@cartermp cartermp deleted the cartermp/format-commands branch April 13, 2023 15:44
@chalin chalin mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cartermp @chalin