-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Language Feature Reference" table in demo docs #2602
Conversation
I think this is incorrect since, at the very minimum, the Java service uses the autoinstrumentation agent. |
But e.g. Go, .NET are using manual instrumentation libraries. Therefore the existing header is misleading. And yes, Java is using autoinstrumentation agent to apply instrumentation libraries 😉 EDIT: I am going to add an additional column per @Kielek suggestion. |
@cartermp I added a separate column. a3bdb57 However, I am not sure if it won't be more readable to remove the whole "Language Feature Reference" section and add more info in "Service Documentation" section. E.g.
WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also https://github.com/open-telemetry/opentelemetry.io/blob/main/content/en/docs/demo/trace-features.md should be adjusted
Related to open-telemetry/opentelemetry-specification#2866
Lots of the things documented under "Auto Instrumentation" are in fact about using "instrumentation libraries".