Node getting started fixes #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #2604 Also cleans up some import/qualifications, and quotes on strings
chalin
approved these changes
Apr 15, 2023
platoyuval
approved these changes
Apr 16, 2023
svrnm
approved these changes
Apr 17, 2023
A note would be fine, but overall we need to compromise at some point between giving options and readability. The TypeScript/JavaScript tabs are already making things much more complicated than for other languages. @platoyuval if you provide a PR with a suggestion I am happy to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2604
Also cleans up some import/qualifications, and quotes on strings
Validated with a local app I created from scratch.