Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.4 release and kubecon blog for demo #2608

Merged
merged 14 commits into from
Apr 18, 2023
Merged

1.4 release and kubecon blog for demo #2608

merged 14 commits into from
Apr 18, 2023

Conversation

cartersocha
Copy link
Contributor

No description provided.

@cartersocha cartersocha requested review from a team as code owners April 16, 2023 19:34
@cartersocha cartersocha requested a review from a team April 16, 2023 19:35
julianocosta89
julianocosta89 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content wise it LGTM 🤩

svrnm
svrnm approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to have that, looks good to me content-wise, please make sure that you fix the formatting

@cartersocha
Copy link
Contributor Author

cartersocha commented Apr 17, 2023 •
edited

I'm getting a really annoying error locally trying to fix the check links / refcache. What am I missing? Are there version requirements? @chalin @svrnm

NVM

@cartersocha
Copy link
Contributor Author

❗ Planning on adding a header picture. Please don't merge until it's added ❗

@austinlparker austinlparker merged commit 4b0f105 into open-telemetry:main Apr 18, 2023
6 checks passed
@cartersocha
Copy link
Contributor Author

It wasn’t ready to merge @austinlparker

@austinlparker
Copy link
Member

austinlparker commented Apr 18, 2023 via email

@austinlparker
Copy link
Member

Ok, I missed the comment, my bad. In my defense it's early.

austinlparker added a commit that referenced this pull request Apr 18, 2023
@austinlparker
Revert "1.4 release and kubecon blog for demo (#2608)"
62a6336 
This reverts commit 4b0f105.
@austinlparker austinlparker mentioned this pull request Apr 18, 2023
Merged
@cartersocha
Copy link
Contributor Author

All good. I’ll just update later and then point to it

@austinlparker
Copy link
Member

You'll need to create a new PR -- sorry, I saw your message in Slack to revert and did so.

@svrnm svrnm mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avillela avillela avillela left review comments

@svrnm svrnm svrnm approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cartersocha @austinlparker @svrnm @fatsheep9146 @julianocosta89 @avillela