Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial draft of lambda guidance #2632

Merged
merged 48 commits into from
May 6, 2023
Merged

initial draft of lambda guidance #2632

merged 48 commits into from
May 6, 2023

Conversation

cartersocha
Copy link
Contributor

@cartersocha cartersocha commented Apr 24, 2023 •
edited by chalin

@svrnm svrnm added enhancement New feature or request sig:faas labels Apr 25, 2023
svrnm
svrnm reviewed Apr 25, 2023
View reviewed changes
content/en/docs/faas/_index.md Outdated Show resolved Hide resolved
content/en/docs/faas/_index.md Outdated Show resolved Hide resolved
@cartersocha cartersocha marked this pull request as ready for review May 1, 2023 22:12
@cartersocha cartersocha requested a review from a team as a code owner May 1, 2023 22:12
svrnm
svrnm previously requested changes May 2, 2023
View reviewed changes
content/en/docs/faas/_index.md Outdated Show resolved Hide resolved
content/en/docs/faas/_index.md Outdated Show resolved Hide resolved
content/en/docs/faas/_index.md Outdated Show resolved Hide resolved
content/en/docs/faas/_index.md Outdated Show resolved Hide resolved
content/en/docs/faas/lambda-auto-instrument.md Outdated Show resolved Hide resolved
content/en/docs/faas/lambda-collector.md Outdated Show resolved Hide resolved
content/en/docs/faas/lambda-collector.md Outdated Show resolved Hide resolved
cartersocha and others added 6 commits May 2, 2023 12:27
@cartersocha
initial comments
2feddfb
@cartersocha @svrnm
Update content/en/docs/faas/_index.md
476de77 
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@cartersocha @svrnm
Update content/en/docs/faas/_index.md
5354e16 
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@cartersocha @svrnm
Update content/en/docs/faas/_index.md
da74056 
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@cartersocha @svrnm
Update content/en/docs/faas/_index.md
5d8518b 
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@cartersocha
update for pr review
f062d2d
cartersocha and others added 15 commits May 5, 2023 12:45
@cartersocha @chalin
Update content/en/docs/faas/lambda-auto-instrument.md
c2bb757 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/_index.md
63a3418 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-auto-instrument.md
c89533f 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-collector.md
d7d1907 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-collector.md
057c186 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-collector.md
546add8 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-manual-instrument.md
577fe2c 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/_index.md
70010b8 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-manual-instrument.md
f321506 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-collector.md
3f4fb43 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-collector.md
453f096 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha @chalin
Update content/en/docs/faas/lambda-auto-instrument.md
dceb040 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha
Merge branch 'main' into lambda-docs
6a4551c
@cartersocha
update link
4d1cff5
@cartersocha @chalin
Update content/en/docs/faas/_index.md
c013403 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartersocha cartersocha requested a review from svrnm May 5, 2023 19:53
@cartersocha
Copy link
Contributor Author

cartersocha commented May 5, 2023 •
edited

ready to go @svrnm

cartermp
cartermp approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes yes yes

@cartermp cartermp dismissed svrnm’s stale review May 6, 2023 15:40

Changes addressed

@cartermp cartermp merged commit 5d56161 into main May 6, 2023
8 checks passed
@cartermp cartermp deleted the lambda-docs branch May 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@tylerbenson tylerbenson tylerbenson left review comments

@chalin chalin chalin left review comments

@rapphil rapphil rapphil left review comments

@bryan-aguilar bryan-aguilar bryan-aguilar left review comments

@cartermp cartermp cartermp approved these changes

@svrnm svrnm Awaiting requested review from svrnm

Assignees
No one assigned
Labels
enhancement New feature or request sig:faas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cartersocha @svrnm @codeboten @tylerbenson @chalin @rapphil @cartermp @bryan-aguilar