Js getting started more updates #2652
Conversation
There was a problem hiding this comment.
See inline comments.
Here's another suggested change. From:
One tool commonly used for this task is the
[`-r, --require module`](https://nodejs.org/api/cli.html#cli_r_require_module)
flag. xTo:
One tool commonly used for this task is the
[--require](https://nodejs.org/api/cli.html#-r---require-module)
flag.Note the corrected URL and hash.
| <details> | ||
| <summary>View example output</summary> | ||
|
|
||
| ```javascript |
There was a problem hiding this comment.
| ```javascript | |
| ```json |
There was a problem hiding this comment.
the output is not json, so some editors scream at you in red when looking at that.
I am OK with both.
There was a problem hiding this comment.
maybe there is a jsonlines option?
There was a problem hiding this comment.
@svrnm, maybe try jsonlines (I'd never tried that one before). If it doesn't work go with which ever option you prefer.
There was a problem hiding this comment.
I put in jsonlines, also not sure if this is a legal argument although it is not screaming at me in red anymore in VSCode, I would say that's a win
|
@dyladan any further feedback? |
| <details> | ||
| <summary>View example output</summary> | ||
|
|
||
| ```javascript |
There was a problem hiding this comment.
maybe there is a jsonlines option?
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Signed-off-by: svrnm <neumanns@cisco.com>
chalin
force-pushed
the
js-getting-started-more-updates
branch
from
6c7ce5d
to
1a736d8
Compare
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
This PR #2651 and #2653 create some consistency across python, java & Node.JS documentation.
Preview:
https://deploy-preview-2652--opentelemetry.netlify.app/docs/instrumentation/js/getting-started/nodejs/