Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tabbed code in PHP page #2656

Merged
merged 2 commits into from
May 5, 2023
Merged

Fix tabbed code in PHP page #2656

merged 2 commits into from
May 5, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 5, 2023 •
edited

@chalin chalin requested review from a team as code owners May 5, 2023 00:01
@chalin chalin mentioned this pull request May 5, 2023
Merged
brettmc
brettmc reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think prettify must have joined the header and first line...

@chalin
Copy link
Contributor Author

chalin commented May 5, 2023

@brettmc - thanks for spotting that. I propose that we fix it by ending the step's leading sentence with a period, and let the rest of the text flow from there. I've committed this change. PTAL

@svrnm svrnm merged commit a2c57a5 into open-telemetry:main May 5, 2023
8 checks passed
@chalin chalin deleted the chalin-im-php-fix-tabbed-code-2023-05-04 branch May 5, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@brettmc brettmc brettmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chalin @svrnm @brettmc