Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental improvements for migration docs #2657

Merged
merged 9 commits into from
May 8, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented May 5, 2023

Some incremental improvements for migration docs:

  • Some introduction for where Otel comes from and why we provide oc & ot migration (copied some of your words @aabmass, hope that's OK :))
  • Also some words about jaeger (copied from the jaeger docs (cc @pavolloffay) & @jpkrohling blog post)
  • Linked to the spec for OpenCensus for now, not sure if this works in the long run and if we might need a separate migration guide like we have one for ot

Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team as a code owner May 5, 2023 13:29
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, love it!

@cartermp
Copy link
Contributor

cartermp commented May 5, 2023

Looks like there's another formatting push to make here 🙃

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

See inline comments for link-check fix and more.

content/en/docs/migration/_index.md Outdated Show resolved Hide resolved
content/en/docs/migration/_index.md Outdated Show resolved Hide resolved
content/en/docs/migration/_index.md Outdated Show resolved Hide resolved
content/en/docs/migration/opencensus.md Outdated Show resolved Hide resolved
.htmltest.yml Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented May 7, 2023

Looks like there's another formatting push to make here 🙃

@cartermp - the formatting seems file (the action is passing) -- unless I missed something. Were you referring to the link-check failure?

svrnm and others added 7 commits May 8, 2023 09:46
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chalin chalin merged commit e9d1485 into open-telemetry:main May 8, 2023
8 checks passed
@svrnm svrnm deleted the some-more-migration-instructions branch May 11, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants