Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: why histograms? #2658

Merged
merged 13 commits into from
May 8, 2023
Merged

Blog: why histograms? #2658

merged 13 commits into from
May 8, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 5, 2023

Guest post from https://dyladan.me/histograms/2023/05/02/why-histograms/

This is the first in a series of 3 posts. The second explains the differences and tradeoffs between histograms and summaries (https://dyladan.me/histograms/2023/05/03/histograms-vs-summaries/). The third explains exponential histograms in detail (https://dyladan.me/histograms/2023/05/04/exponential-histograms/).

Please feel free to share any editing or copy suggestions.


Preview: https://deploy-preview-2658--opentelemetry.netlify.app/blog/2023/why-histograms/

@dyladan dyladan requested review from a team as code owners May 5, 2023 15:22
@cartermp
Copy link
Contributor

cartermp commented May 5, 2023

FYI - formatting check failed, but since we're probably going to do copy-edits, let's minimize your pain and only have you reformat stuff until after we're satisfied with the content 🙂

@dyladan
Copy link
Member Author

dyladan commented May 5, 2023

FYI - formatting check failed, but since we're probably going to do copy-edits, let's minimize your pain and only have you reformat stuff until after we're satisfied with the content 🙂

It's just as easy to do it now. Reviews may be easier if things are in the expected format.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, thank you! Mostly some small copy-edits, but I modified the last paragraph a a bit to caveat about backends and sampling strategies. Since accurate calculations of SLOs is a super deep topic we probably shouldn't elaborate too much, but I do think we should call out that the problems you can run into won't be the same from backend to backend.

content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, thanks.

content/en/blog/2023/why-histograms/index.md Outdated Show resolved Hide resolved
@dyladan
Copy link
Member Author

dyladan commented May 6, 2023

updated the date to monday may 8th to reflect when this is likely to be merged

@dyladan
Copy link
Member Author

dyladan commented May 6, 2023

If a maintainer merges this before that obviously they can change the date. I have enabled "allow edits from maintainers" on the PR

@dyladan
Copy link
Member Author

dyladan commented May 6, 2023

@cartermp @chalin I rewrote the section "Other metric types" because on re-reading I noticed that the wording was technically incorrect. The last paragraph previously stated that collecting each percentile as a gauge is an ad-hoc implementation of histograms, when this is actually much closer to a summary metric type. I also added a caveat that summaries cannot be aggregated across hosts. PTAL

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great content. Unless there's no other objections, I'll merge this on Monday and it'll be live.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cartermp
Copy link
Contributor

cartermp commented May 8, 2023

🎉

@cartermp cartermp merged commit e5cfe0f into open-telemetry:main May 8, 2023
8 checks passed
@dyladan dyladan deleted the why-histograms branch May 8, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants