Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete superfluous imports and add quotation marks in getting-started.md #2679

Merged
merged 4 commits into from
May 10, 2023

Conversation

matthiasa4
Copy link
Contributor

No description provided.

@matthiasa4 matthiasa4 requested review from a team as code owners May 9, 2023 06:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: matthiasa4 / name: Matthias Baetens (9ea9aa9)

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@open-telemetry/python-approvers PTAL

Preview: https://deploy-preview-2679--opentelemetry.netlify.app/docs/instrumentation/python/getting-started/

@matthiasa4
Copy link
Contributor Author

Thanks @svrnm & @cartermp - it looks like I won't be able to merge myself - is it ok if I leave updating the branch and merging to you?

@svrnm
Copy link
Member

svrnm commented May 10, 2023

Thanks @svrnm & @cartermp - it looks like I won't be able to merge myself - is it ok if I leave updating the branch and merging to you?

Yes, that's what we do as maintainers 😆 ... we wait a while for the @open-telemetry/python-approvers to give it a look and then we can merge it in

@matthiasa4
Copy link
Contributor Author

Haha, fair point @svrnm - wasn't trying to rush it, just curious. First contribution in OpenTelemetry & first time I see the code owners feature being used which is quite cool! So all code is quadruple checked? (4 reviewers?)

@svrnm
Copy link
Member

svrnm commented May 10, 2023

Haha, fair point @svrnm - wasn't trying to rush it, just curious. First contribution in OpenTelemetry & first time I see the code owners feature being used which is quite cool! So all code is quadruple checked? (4 reviewers?)

No worries, I just wanted to manage expectations, happy to have you contribute :-) All code is checked by 2 parties: open-telemetry/docs-approvers and the maintainers/approvers of the individual sub-project (here open-telemetry/python-approvers). Technically there is only 1 approval required but we aim for having both parties to provide at least 1 approval. You can look into https://github.com/open-telemetry/opentelemetry.io/blob/main/.github/CODEOWNERS for more details

@cartermp
Copy link
Contributor

I took in a separate PR that only fixed the quotes since that was a bug fix. I think we can probably just take this as-is since it's superfluous imports and not really changing the code behaviorally.

@svrnm svrnm merged commit 30e21c5 into open-telemetry:main May 10, 2023
8 checks passed
@svrnm
Copy link
Member

svrnm commented May 10, 2023

thank you for your contribution @matthiasa4

@matthiasa4
Copy link
Contributor Author

Thank you @svrnm - hope there is more to come :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants