-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete superfluous imports and add quotation marks in getting-started.md #2679
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
@open-telemetry/python-approvers PTAL
Preview: https://deploy-preview-2679--opentelemetry.netlify.app/docs/instrumentation/python/getting-started/
Haha, fair point @svrnm - wasn't trying to rush it, just curious. First contribution in OpenTelemetry & first time I see the |
No worries, I just wanted to manage expectations, happy to have you contribute :-) All code is checked by 2 parties: open-telemetry/docs-approvers and the maintainers/approvers of the individual sub-project (here open-telemetry/python-approvers). Technically there is only 1 approval required but we aim for having both parties to provide at least 1 approval. You can look into https://github.com/open-telemetry/opentelemetry.io/blob/main/.github/CODEOWNERS for more details |
I took in a separate PR that only fixed the quotes since that was a bug fix. I think we can probably just take this as-is since it's superfluous imports and not really changing the code behaviorally. |
thank you for your contribution @matthiasa4 |
Thank you @svrnm - hope there is more to come :) |
No description provided.