Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Automatic Instrumentation Section for JS #2681

Merged
merged 11 commits into from
May 17, 2023
Merged

Add Automatic Instrumentation Section for JS #2681

merged 11 commits into from
May 17, 2023

Conversation

samimusallam
Copy link
Member

Added a JS Auto instrumentation section explaining how to set up and configure the module.

@samimusallam samimusallam changed the title feat(js-auto-instrumentation): Added Automatic Instrumentation Section for JS Add Automatic Instrumentation Section for JS May 9, 2023
@avzis
Copy link

avzis commented May 9, 2023

Preview of the changes:
https://deploy-preview-2681--opentelemetry.netlify.app/docs/instrumentation/js/automatic/
https://deploy-preview-2681--opentelemetry.netlify.app/docs/instrumentation/js/automatic/module-config/

@cartermp
Copy link
Contributor

cartermp commented May 9, 2023

Hey @samimusallam I realize this is just a draft, but in /module-config/ it would be great to have an in-code example that shows how to disable specific instrumentations or modify the config of one of the ones brought in by the meta-package.

@svrnm
Copy link
Member

svrnm commented May 10, 2023

@%!!# ... I am so excited about this @samimusallam! 😍

@samimusallam
Copy link
Member Author

@%!!# ... I am so excited about this @samimusallam! 😍

Same here! This has been a long-awaited feature for JS 🚀

@samimusallam
Copy link
Member Author

samimusallam commented May 10, 2023 •
edited

Hey @samimusallam I realize this is just a draft, but in /module-config/ it would be great to have an in-code example that shows how to disable specific instrumentations or modify the config of one of the ones brought in by the meta-package.

Sadly, that functionality does not exist, there is no way of disabling specific instrumentation through environment variables.
The JS auto-configuration feature will solve this issue, but I'm not sure what the progress is on that.

@samimusallam samimusallam marked this pull request as ready for review May 16, 2023 13:55
@samimusallam samimusallam requested review from a team as code owners May 16, 2023 13:55
svrnm
svrnm approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, minor nit.

content/en/docs/instrumentation/js/automatic/_index.md Outdated Show resolved Hide resolved
@samimusallam @svrnm
Update content/en/docs/instrumentation/js/automatic/_index.md
353aa28 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@svrnm svrnm mentioned this pull request May 16, 2023
Merged
@svrnm svrnm merged commit 832d0a1 into open-telemetry:main May 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@arbiv arbiv arbiv left review comments

@martinkuba martinkuba martinkuba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samimusallam @avzis @cartermp @svrnm @martinkuba @arbiv