Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Observe, Inc. to the vender list. #2706

Merged
merged 6 commits into from
May 15, 2023
Merged

Add Observe, Inc. to the vender list. #2706

merged 6 commits into from
May 15, 2023

Conversation

NathanNam
Copy link
Contributor

No description provided.

@NathanNam NathanNam requested a review from a team as a code owner May 12, 2023 00:12
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 12, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: NathanNam / name: Nathan (Dae Hyun) Nam (3a4298d)

@svrnm
Copy link
Member

svrnm commented May 12, 2023

@NathanNam please sign the CLA so we can proceed reviewing it

cartermp
cartermp approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; we'd prefer docs links if you got them over a blog post, but this certainly meets the requirements.

@NathanNam
Update vendors.md
de428f8 
Changed the link to the Observe documentation.
@NathanNam
Copy link
Contributor Author

LGTM; we'd prefer docs links if you got them over a blog post, but this certainly meets the requirements.

Changed the link to the documentation page (https://docs.observeinc.com/en/latest/content/integrations/otel/opentelemetry.html).

@svrnm
Copy link
Member

svrnm commented May 15, 2023

LGTM; we'd prefer docs links if you got them over a blog post, but this certainly meets the requirements.

Changed the link to the documentation page (https://docs.observeinc.com/en/latest/content/integrations/otel/opentelemetry.html).

When you add URLs you need to run npm run test to get the refcache updated accordingly.

@NathanNam
Copy link
Contributor Author

LGTM; we'd prefer docs links if you got them over a blog post, but this certainly meets the requirements.

Changed the link to the documentation page (https://docs.observeinc.com/en/latest/content/integrations/otel/opentelemetry.html).

When you add URLs you need to run npm run test to get the refcache updated accordingly.

When I ran npm run test, I got the following error. I'm not sure whether these errors were caused by changes I made on vendors.md.

Start building sites …
hugo v0.111.3-5d4eb5154e1fed125ca8e9b5a0315c4180dab192+extended darwin/arm64 BuildDate=2023-03-12T11:40:50Z VendorInfo=gohugoio
ERROR 2023/05/15 09:20:42 render of "page" failed: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/layouts/_default/baseof.html:19:7": execute of template failed: template: _default/single.html:19:7: executing "_default/single.html" at <partialCached "scripts.html" .>: error calling partialCached: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/partials/scripts.html:84:30": execute of template failed: template: partials/scripts.html:84:30: executing "partials/scripts.html" at <resources.Concat>: error calling Concat: slice []interface {} not supported in concat
ERROR 2023/05/15 09:20:42 render of "page" failed: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/blog/baseof.html:33:7": execute of template failed: template: blog/single.html:33:7: executing "blog/single.html" at <partial "scripts.html" .>: error calling partial: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/partials/scripts.html:84:30": execute of template failed: template: partials/scripts.html:84:30: executing "partials/scripts.html" at <resources.Concat>: error calling Concat: slice []interface {} not supported in concat
ERROR 2023/05/15 09:20:42 render of "page" failed: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/blog/baseof.html:33:7": execute of template failed: template: blog/single.html:33:7: executing "blog/single.html" at <partial "scripts.html" .>: error calling partial: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/partials/scripts.html:84:30": execute of template failed: template: partials/scripts.html:84:30: executing "partials/scripts.html" at <resources.Concat>: error calling Concat: slice []interface {} not supported in concat
ERROR 2023/05/15 09:20:42 render of "page" failed: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/blog/baseof.html:33:7": execute of template failed: template: blog/single.html:33:7: executing "blog/single.html" at <partial "scripts.html" .>: error calling partial: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/partials/scripts.html:84:30": execute of template failed: template: partials/scripts.html:84:30: executing "partials/scripts.html" at <resources.Concat>: error calling Concat: slice []interface {} not supported in concat
ERROR 2023/05/15 09:20:42 failed to render pages: render of "page" failed: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/layouts/_default/baseof.html:19:7": execute of template failed: template: _default/search.html:19:7: executing "_default/search.html" at <partialCached "scripts.html" .>: error calling partialCached: "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/layouts/partials/scripts.html:84:30": execute of template failed: template: partials/scripts.html:84:30: executing "partials/scripts.html" at <resources.Concat>: error calling Concat: slice []interface {} not supported in concat
Error: Error building site: TOCSS: failed to transform "scss/main.scss" (text/x-scss): "/Users/nathan.nam/Documents/GitHub/NathanNam/opentelemetry.io/themes/docsy/assets/scss/main.scss:1:1": File to import not found or unreadable: ../vendor/bootstrap/scss/functions.
Total in 1298 ms
ERROR: "check:links" exited with 255.

@chalin
Copy link
Contributor

chalin commented May 15, 2023

Hi. I get the impression that you might not have run npm install? For setup details, see https://github.com/open-telemetry/opentelemetry.io/blob/main/CONTRIBUTING.md#local-setup. Only after can you run the test script.

@NathanNam
Copy link
Contributor Author

Hi. I get the impression that you might not have run npm install? For setup details, see https://github.com/open-telemetry/opentelemetry.io/blob/main/CONTRIBUTING.md#local-setup. Only after can you run the test script.

npm install -> npm run test solved my issue. Thank you all!

@cartermp cartermp merged commit f4edce6 into open-telemetry:main May 15, 2023
8 checks passed
@NathanNam NathanNam deleted the patch-2 branch May 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NathanNam @svrnm @chalin @cartermp