Add connectors to collector doc #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
May 12, 2023
| > pipelines within the [service](#service) section. | ||
|
|
||
| One or more connectors may be configured. By default, no receivers are | ||
| configured. A basic example of all available connectors is provided below. |
There was a problem hiding this comment.
This is missing the forward connector.
Is it really intended that this will be kept up to date with examples for all connectors? If not, I'd suggest removing that word.
There was a problem hiding this comment.
I copied that sentence from the section for receivers not reading that "all" there, we probably should not have that at any place, thanks for noticing!
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
djaglowski
approved these changes
May 12, 2023
cartermp
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor addition: add connectors to the collector docs