-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove concept page 'Data Collection' #2761
Remove concept page 'Data Collection' #2761
Conversation
Yes, I agree it should probably be removed. As a note, it did get ~14k hits last month: https://play.honeycomb.io/opentelemetry-web/datasets/opentelemetry.io/result/H3QyLkcPGYu?useStackedGraphs So we should set up an appropriate redirect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+1 to the redirect -- either as an alias in the new target file, or a redirect rule
(and the three broken links will need to be addressed)
Redirection is a good point, what would be a good target? https://opentelemetry.io/docs/collector/? |
Yeah, that's about what I'd expect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svrnm - I'm wondering if it would make more sense to redirect /docs/concepts/data-collection/
to /docs/concepts/components/#collector
instead, that way it stays within the Concepts section.
@@ -11,7 +11,7 @@ support multiple [signals](../signals). The reference implementation of | |||
OpenTelemetry is available as: | |||
|
|||
- [Language-specific instrumentation libraries](../instrumenting) | |||
- [A Collector binary](../data-collection) | |||
- [A Collector binary](/docs/collector) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use canonical path (with trailing /
):
- [A Collector binary](/docs/collector) | |
- [A Collector binary](/docs/collector/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@svrnm @cartermp - not sure if you missed this comment (#2761 (review)):
WDYT? |
I think that we should remove the following page:
https://opentelemetry.io/docs/concepts/data-collection/
It mostly holds redundant and outdated information:
@open-telemetry/collector-approvers PTAL as well
Preview: https://deploy-preview-2761--opentelemetry.netlify.app/docs/
Redirect test: