-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure concept pages for instrumentation #2763
Merged
svrnm
merged 11 commits into
open-telemetry:main
from
svrnm:restructure-concept-pages-for-instrumentation
Jun 6, 2023
Merged
Restructure concept pages for instrumentation #2763
svrnm
merged 11 commits into
open-telemetry:main
from
svrnm:restructure-concept-pages-for-instrumentation
Jun 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
reviewed
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline for a few initial minor comments.
@chalin any idea why the html checker is failing?
|
chalin
force-pushed
the
restructure-concept-pages-for-instrumentation
branch
from
May 26, 2023 11:53
b9005fd
to
780f73e
Compare
chalin
approved these changes
Jun 5, 2023
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
chalin
force-pushed
the
restructure-concept-pages-for-instrumentation
branch
from
June 5, 2023 15:49
4d5a312
to
0fa3395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the structure of the concept pages for instrumentation with what we have for the language-specific pages (sub pages "manual", "automatic" and "libraries"), this hopefully also allows people to find those pages easier.
Preview: https://deploy-preview-2763--opentelemetry.netlify.app/docs/concepts/instrumentation/
Redirect tests: