-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https scheme ins grpc env var exporter examples #2863
Conversation
If the endpoint always comes with the scheme, then what's the use of |
|
Is it described in any specification?
Also, for signed keys, there should be a way to specify the key server used to verify the server identity, rather than just ignoring the certificate from server. Will this PR cause a compatibility problem? I'm fine with the format, as long as the value can be accepted accross the ecosystem. |
May bad, I was wrong here! From the spec [1]:
I should have done more reading on the issue, I have to admit I was not even aware of that combination of environment variables. From a documentation standpoint having the schema is our best option, it leads to the least issues, since languages MUST support that schema (similar to what @jack-berg stated here about Java: open-telemetry/opentelemetry-java#5517 (comment)). Outside documentation, if any language does not support schema, this is a bug and needs to be fixed. We can call that out in the documentation until the bug is fixed. |
It seems the python implementation can accept the export variable with shceme, but when it has conflict with our application when auto-instrument enabled, I'll inspect it later. |
@hu6360567 do you have any issue open here? https://github.com/open-telemetry/opentelemetry-python-contrib I would bet they're keen on fixing the issue. |
fixes #2861