Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Go website_docs into opentelemetry.io repo #2872

Merged
merged 7 commits into from
Jun 17, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 14, 2023

  • Closes Move Go and Ruby docs into this repo #1935
  • Contributes to Move website_docs to OTel website repo opentelemetry-go#4214
  • Steps:
    • Refreshed git rm content-modules/opentelemetry-go
    • Copied pages: cp -R content-modules/opentelemetry-go/website_docs content/en/docs/instrumentation/go
    • Updated _index.md:
      • Removed github_repo and other cascaded page-meta front-matter fields
      • Replaced use of lang_instrumentation_index_head by new shortcode
    • git rm content-modules/opentelemetry-go
  • Drops hugo.yaml mount point of Go submodule
  • Cleans up Prettier ignore file to eliminate special Go submodule rules
  • Adds appropriate entry for @open-telemetry/go-instrumentation-approvers to CODEOWNERS
  • Deleted now obsolete lang_instrumentation_index_head shortcode.

Preview: https://deploy-preview-2872--opentelemetry.netlify.app/docs/instrumentation/go/

No changes to the generated site files (aside from redirect-rule reordering) after the files got moved:

$ (cd public && git diff -- . ':(exclude)*.xml') | grep ^diff  
diff --git a/_redirects b/_redirects

/cc @MrAlias

@chalin chalin requested a review from a team June 14, 2023 20:00
@chalin chalin requested a review from a team as a code owner June 14, 2023 20:00
@chalin chalin force-pushed the chalin-im-go-docs-2023-06-14 branch from 0f1ea70 to d66c182 Compare June 14, 2023 20:07
@chalin chalin changed the title Move Go website_docs into this repo Move Go website_docs into opentelemetry.io repo Jun 14, 2023
@cartermp
Copy link
Contributor

🎉

@cartermp cartermp merged commit a6a6b30 into open-telemetry:main Jun 17, 2023
8 checks passed
@chalin chalin deleted the chalin-im-go-docs-2023-06-14 branch June 17, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Go and Ruby docs into this repo
4 participants