Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to metrics concept page #2879

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 16, 2023

Based on the feedback from #2877, I tried to improve some of the metrics concept page:

  • I gave it a structure that is closer to the one we have for traces already (i.e. calling out components like MeterProvider, Meter, etc.)
  • Added a metrics support table that (a) provides a link to the languages, and (b) calls out metric stability across them, such that an end user is not going to be surprised if for a specific language they can not find metric instructions

If the latter proves valuable for metrics I can create the same for traces (and later for logs)

@svrnm svrnm requested a review from a team as a code owner June 16, 2023 09:31
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement over the current...sparse...docs.

@cartermp cartermp merged commit 170fa9b into open-telemetry:main Jun 16, 2023
8 checks passed
@svrnm svrnm deleted the update-metrics-concept-page branch September 20, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants