Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update arns for lambda docs #2894

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Conversation

cartersocha
Copy link
Contributor

No description provided.

@cartersocha cartersocha marked this pull request as ready for review June 20, 2023 21:25
@cartersocha cartersocha requested a review from a team as a code owner June 20, 2023 21:25
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you run npm run test to update the refcache?

@cartersocha
Copy link
Contributor Author

@cartermp I did and it fails 😢 Initial debugging didn't raise any obvious issues. I'm on a Mac M2 and tried it on an M1. Tried a fresh fork.
Screenshot 2023-06-20 at 5 27 09 PM

@svrnm
Copy link
Member

svrnm commented Jun 21, 2023

@cartermp I did and it fails 😢 Initial debugging didn't raise any obvious issues. I'm on a Mac M2 and tried it on an M1. Tried a fresh fork.

Using a M1 myself, and it works without issues, so the problem may lay somewhere else. I fixed the URL check on your behave, but let's raise another issue to figure out what's wrong here.

@svrnm svrnm mentioned this pull request Jun 21, 2023
@cartermp cartermp merged commit c638a46 into open-telemetry:main Jun 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants