Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop schema 1.21.0 #2924

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Drop schema 1.21.0 #2924

merged 1 commit into from
Jun 28, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 28, 2023 •
edited 

$ npm run build 
...
$ (cd public && git status)
On branch main
...
        deleted:    schemas/1.21.0

/cc @jsuereth @tigrannajaryan @open-telemetry/specs-semconv-approvers

@chalin chalin requested a review from a team as a code owner June 28, 2023 12:59
@chalin chalin mentioned this pull request Jun 28, 2023
Merged
@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

@jsuereth - should we wait for feedback on open-telemetry/opentelemetry-specification#3572 before merging this PR?

@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

I see that @jsuereth and @joaopgrassi, you are both members of https://github.com/orgs/open-telemetry/teams/specs-semconv-approvers -- two members approving passed the gating criteria. Merging.

@chalin chalin merged commit 4c23861 into open-telemetry:main Jun 28, 2023
8 checks passed
@chalin chalin deleted the chalin-im-drop-schema-1.21.0-2023-06-28 branch June 28, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop 1.21.0 schema
3 participants
@chalin @jsuereth @joaopgrassi