Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpAMP spec #2926

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Add OpAMP spec #2926

merged 2 commits into from
Jun 28, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 28, 2023 •
edited

@chalin chalin requested a review from a team as a code owner June 28, 2023 17:03
@chalin chalin mentioned this pull request Jun 28, 2023
Closed
2 tasks
@chalin chalin marked this pull request as draft June 28, 2023 17:22
@chalin chalin force-pushed the chalin-im-opamp-spec-2023-06-28 branch from f88434b to 8d2ba09 Compare June 28, 2023 17:31
@chalin chalin marked this pull request as ready for review June 28, 2023 17:32
@chalin chalin marked this pull request as draft June 28, 2023 17:35
tigrannajaryan
tigrannajaryan approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

Thanks for the review @tigrannajaryan. I'm resolving link issues; it'll be good to go after that.

@chalin chalin marked this pull request as ready for review June 28, 2023 18:04
@chalin chalin force-pushed the chalin-im-opamp-spec-2023-06-28 branch from 94f06bf to 2ae49dd Compare June 28, 2023 18:05
@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

@svrnm @cartermp this is ready for review and merge, if approved (once all tests pass).

@svrnm
Copy link
Member

svrnm commented Jun 28, 2023 •
edited

@chalin can we make sure that the otel spec is always the first one? Right now OpAMP is listed before the otel spec

beyond that lgtm

@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

I'll address the spec order in a followup PR. Would that be ok @svrnm?

@chalin chalin merged commit 4c11dea into open-telemetry:main Jun 28, 2023
8 checks passed
@chalin chalin deleted the chalin-im-opamp-spec-2023-06-28 branch June 28, 2023 19:33
@chalin
Copy link
Contributor Author

chalin commented Jun 28, 2023

@svrnm - FYI, will track the spec ordering change via:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees
No one assigned
Labels
sig:spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OpAMP spec to the specs list
3 participants
@chalin @svrnm @tigrannajaryan