Fix Collector configuration issues #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
reviewed
Oct 27, 2023
cartermp
approved these changes
Oct 31, 2023
chalin
force-pushed
the
theletterf-fix-config-collector-issues
branch
from
5162477
to
fd81f8b
Compare
chalin
reviewed
Oct 31, 2023
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
…heletterf/opentelemetry.io into theletterf-fix-config-collector-issues
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
chalin
approved these changes
Nov 8, 2023
|
@svrnm This one can be merged, I think. |
We need approval from someone from @open-telemetry/collector-approvers |
codeboten
reviewed
Nov 21, 2023
…heletterf/opentelemetry.io into theletterf-fix-config-collector-issues
|
@codeboten Changes applied! |
|
@codeboten does this look good? |
|
@theletterf can you take a look at the conflict? I think this is related to some changes to the images I introduced yesterday, so it should not have any impact on the content. |
|
@svrnm Should be solved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697 and adds some rewrites for clarity.
Preview: https://deploy-preview-3443--opentelemetry.netlify.app/docs/collector/configuration/