[IA] More shortcodes for exporter pages #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <neumanns@cisco.com>
|
Is there a reason why this is a draft? |
I didn't want to trigger all the maintainers yet. Get your (docs) feedback first |
cartermp
reviewed
Feb 2, 2024
theletterf
approved these changes
Feb 5, 2024
cartermp
approved these changes
Feb 5, 2024
Kielek
approved these changes
Feb 7, 2024
chalin
reviewed
Feb 7, 2024
|
|
||
| {{/* | ||
| below list needs to grow until all languages are updated to a consistent structure. | ||
| */}} {{ if in (slice "python" "js" "java") $lang -}} |
There was a problem hiding this comment.
@svrnm - instead of {{ if in (slice "python" "js" "java") $lang -}} should a field be added to the data file?
There was a problem hiding this comment.
Let's track this via:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3859, this PR heavily applies shortcodes to deduplicate content across exporter pages (currently java, python, JS)
@open-telemetry/docs-approvers PTAL!