Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker as a prerequisite to Collector quick start example #4143

Merged
merged 3 commits into from Mar 14, 2024

Conversation

cthain
Copy link
Contributor

@cthain cthain commented Mar 12, 2024

This PR proposes to add Docker as a prerequisite for the Collector quick start example. Althought Docker is ubitquitous for running applications, if it is not installed on the user's machine, it requires setup prior to running this example.

@cthain cthain requested review from a team as code owners March 12, 2024 13:59
@cthain cthain requested review from dmitryax and removed request for a team March 12, 2024 13:59
Copy link

linux-foundation-easycla bot commented Mar 12, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cthain / name: Chris Thain (a8086f0, bd97302)
  • ✅ login: svrnm / name: Severin Neumann (546060a)

@cthain cthain changed the title Add Docker as a prerequisite. Add Docker as a prerequisite to Collector quick start example Mar 12, 2024
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider applying the suggestion. Thanks!

content/en/docs/collector/quick-start.md Outdated Show resolved Hide resolved
cthain and others added 2 commits March 12, 2024 07:56
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
@svrnm svrnm merged commit 66519da into open-telemetry:main Mar 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants