-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting-started.md with Bandit #4518
Conversation
@pdgonzalez872 thanks for raising this PR! Can you provide some details on the background for this PR? From my point of view the getting started should only make use of one webserver and then exercise the whole example with it. In other languages we have a section at the top that calls out that instrumentation is available for other languages, we can add this for sure. |
@svrnm The framework Phoenix only in the last release changed its default to the web server Bandit. So I think this was meant to cover the case for users on the latest Phoenix as well as still on previous versions who are looking to add OpenTelemetry. Maybe just leaning in on the latest makes sense though. |
Thanks @tsloughter that helps! Then this change makes sense. |
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@tsloughter is spot on. I'd still try to have both the old and the new web servers as options if possible. Even though it's the new default, it is still somewhat rare. The docs, especially, the getting started, should help folks hit the ground running, that's why I went the old/new approach. WDYT? |
/easycla |
works for me, if someone from @open-telemetry/erlang-approvers approves this PR we can do that. |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9208653847 |
No description provided.