Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting-started.md: Add fmt import and remove unused import #4624

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Update getting-started.md: Add fmt import and remove unused import #4624

merged 3 commits into from
Jun 7, 2024

Conversation

sstoner
Copy link
Contributor

@sstoner sstoner commented Jun 7, 2024

This PR addresses errors encountered while following the getting started guide for Go on OpenTelemetry.

go run .
# dice
./rolldice.go:14:2: "go.opentelemetry.io/otel/sdk/instrumentation" imported and not used
./rolldice.go:44:9: undefined: fmt

@sstoner sstoner requested review from a team as code owners June 7, 2024 15:55
@github-actions github-actions bot added the sig:go label Jun 7, 2024
@cartermp cartermp merged commit 2a415f7 into open-telemetry:main Jun 7, 2024
16 checks passed
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jun 8, 2024
@sstoner @cartermp @ymotongpoo
Update getting-started.md: Add fmt import and remove unused import (o…
7b04dd2 
…pen-telemetry#4624)

Signed-off-by: Vancl <liyannois@gmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
sig:go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sstoner @dmathieu @MrAlias @cartermp