Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing JS instrumentations to registry #626

Merged
merged 3 commits into from Jul 8, 2021
Merged

Add missing JS instrumentations to registry #626

merged 3 commits into from Jul 8, 2021

Conversation

jtmalinowski
Copy link
Contributor

No description provided.

@jtmalinowski jtmalinowski mentioned this pull request Jul 5, 2021
Closed
rauno56
rauno56 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few missing from contrib still. At least restify and router, if you don't mind adding those as well. Didn't do an exhaustive check.

@jtmalinowski
Copy link
Contributor Author

All Node.js contrib instrumentations are now in. Thanks @rauno56

@jtmalinowski jtmalinowski mentioned this pull request Jul 6, 2021
Closed
@flands flands merged commit 3472395 into open-telemetry:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flands flands flands approved these changes

@rauno56 rauno56 rauno56 approved these changes

@MetinSeylan MetinSeylan MetinSeylan approved these changes

@austinlparker austinlparker Awaiting requested review from austinlparker

@jparsana jparsana Awaiting requested review from jparsana

@mtwo mtwo Awaiting requested review from mtwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtmalinowski @flands @rauno56 @MetinSeylan