Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uncompressed bytes to receiver and exporter span attributes #149

Merged

Conversation

moh-osman3
Copy link
Contributor

@moh-osman3 moh-osman3 commented Feb 6, 2024

This PR adds a new method to the netstats reporter, called SetSpanAttributes. This method adds uncompressed request size as an attribute to the provided span and explicitly sets the span status in the case of an error. This method is used to track errors for both server.Send and client.Send grpc operations.

@moh-osman3 moh-osman3 force-pushed the mohosman/instrument-size-requests branch from 2d3675f to 5521065 Compare February 7, 2024 09:44
@moh-osman3 moh-osman3 marked this pull request as ready for review February 8, 2024 00:51
@moh-osman3 moh-osman3 requested a review from jmacd February 8, 2024 20:46
@jmacd jmacd merged commit cfd4ede into open-telemetry:main Feb 8, 2024
2 checks passed
jmacd added a commit that referenced this pull request Feb 14, 2024
Includes instrumentation changes, core collector upgrade and some
cleanup.

Included PRs:
- #146
- #149
- #150
- #151
- #153

---------

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants