Fix decoding issue (#158) #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events such as schema update, dictionary upgrade, dictionary overflow are now notified to the ProducerObserver.
Events such as schema update, dictionary upgrade, dictionary overflow are now notified to the ProducerObserver.
…erflow event for some workload
# Conflicts: # collector/go.mod # collector/go.sum
… batch size and batch per stream
# Conflicts: # tools/trace_producer_simu/main.go
moh-osman3
approved these changes
Mar 21, 2024
jmacd
approved these changes
Mar 26, 2024
jmacd
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes with empty keys were already ignored, but not attributes with no value. In this PR, I consider an attribute with no value as malformed or invalid, so they are ignored.
Let me know if this is not the behavior you expected.
Closes: #158