Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the gen/ package directory; move components appropriately #9

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Aug 14, 2023

Part of #3

The collector/gen subdirectory has been used to copy code to and from the https://github.com/open-telemetry/otel-arrow-collector repository, with one exception (fileexporter) which has been there to benefit from the internal/ code. Everything in the gen directory moves one level up, in addition to the primary components being renamed:

  • otlpexporter becomes otelarrowexporter
  • otlpreceiver becomes otelarrowreceiver

All the associated import statements are updated.

@jmacd jmacd requested a review from lquerel as a code owner August 14, 2023 21:25
@jmacd jmacd changed the title Remove the gen/ package directory; move compnents appropriately Remove the gen/ package directory; move components appropriately Aug 14, 2023
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd merged commit 95211c5 into open-telemetry:main Aug 14, 2023
2 checks passed
@jmacd jmacd deleted the jmacd/comp_dirs branch August 14, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants