Skip to content

Commit

Permalink
Fix DOUBLE enum
Browse files Browse the repository at this point in the history
  • Loading branch information
Tigran Najaryan committed Oct 18, 2019
1 parent 7b472c1 commit 77f4b41
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions text/0059-otlp-trace-data-format.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,17 +271,16 @@ message AttributeKeyValue {
STRING = 0;
BOOL = 1;
INT64 = 2;
FLOAT64 = 3;
BINARY = 4;
DOUBLE = 3;
};
string key = 1;
// The type of the value.
ValueType type = 2;
// Only of the following fields is supposed to contain data (determined by `type` field value).
// This is deliberately not using Protobuf `oneof` for performance reasons (verified by benchmarks).
// A string up to 256 bytes long.
string string_value = 3;
// A 64-bit signed integer.
Expand All @@ -290,10 +289,7 @@ message AttributeKeyValue {
bool bool_value = 5;
// A double value.
double double_value = 6;
// A binary value of bytes.
bytes binary_value = 7;
}
```

## Trade-offs and mitigations
Expand Down

0 comments on commit 77f4b41

Please sign in to comment.