Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate semantic conventions from the specification. #227

Merged
merged 30 commits into from May 5, 2023

Conversation

jsuereth
Copy link
Contributor

This should enable us to move quicker and provide better fine-grained ownership of semantic conventions going forward.

text/????-separate-semantic-conventions.md Outdated Show resolved Hide resolved
text/????-separate-semantic-conventions.md Outdated Show resolved Hide resolved
text/????-separate-semantic-conventions.md Outdated Show resolved Hide resolved
@jsuereth jsuereth marked this pull request as ready for review March 21, 2023 14:19
@jsuereth jsuereth requested a review from a team as a code owner March 21, 2023 14:19
text/0227-separate-semantic-conventions.md Outdated Show resolved Hide resolved
text/0227-separate-semantic-conventions.md Outdated Show resolved Hide resolved
text/0227-separate-semantic-conventions.md Show resolved Hide resolved
@dyladan
Copy link
Member

dyladan commented Mar 21, 2023

Given our discussion in the SIG meeting today, maybe we should consider instead of a Semantic Conventions repository, an Instrumentation repository which contains semantic conventions as well as guidelines for instrumentation authors. This would create a single place where instrumentation authors can look to make sure they're following all recommendations without bloating the spec with non-normative guidance for every cross-language instrumentation.


I also don't see addressed here:

  1. ECS is not signal-specific but our semantic conventions are. This might be a good time to bridge this gap by making a dictionary of signal-agnostic attribute definitions which is referenced by signal-specific semantic conventions for their use.
  2. Will the tooling be moved from the build-utils repository into this one? Since the tooling is semconv-specific it might make sense for it to be maintained by the semconv authors and live in the same place.

@jsuereth
Copy link
Contributor Author

@dyladan A few responses:

ECS is not signal-specific but our semantic conventions are. This might be a good time to bridge this gap by making a dictionary of signal-agnostic attribute definitions which is referenced by signal-specific semantic conventions for their use.

This is somewhat called out in future work. I think directionally we're moving our notion of horizontal/vertical to be more use-case based (e.g. HTTP, networking, etc.) conventions vs. signal specific. HOWEVER, for initial transitiion (to preserve git history) we would move that way as a follow on, not the initial move.

Will the tooling be moved from the build-utils repository into this one? Since the tooling is semconv-specific it might make sense for it to be maintained by the semconv authors and live in the same place.

I can directly address this. It's related to a concern @Aneurysm9 raised regarding semconv exports today.

The new directory will come with automated tooling and build-tools will be updated to work with this new directory. There are some details I'd consider OUTSIDE the OTEP (but MUST be figured out as part of the transition) for how codegen should work on a language specific basis.

If you want to see that in this OTEP, then I can move it back to draft form and meet with each language SiG to figure out details for non-breaking migration of this codegen.

On instrumentation vs. semantic conventions

I just don't think we want to expand scope of semantic conventions that far right now. That' worth a discussion of its own, but well outside the scope of this PR. I'm personally against expanding the scope of semantic conventions, but I'd be ok if we have supplementary & non-normative aides for instrumentation authors if we feel it's necessary.

Additionally, if we call the repository "Instrumentation" people may actually look for implementation, when in fact this is just a specification of sorts.

jsuereth and others added 3 commits March 21, 2023 13:42
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@dyladan
Copy link
Member

dyladan commented Mar 21, 2023

I can accept most of that.

On instrumentation vs. semantic conventions

I just don't think we want to expand scope of semantic conventions that far right now. That' worth a discussion of its own, but well outside the scope of this PR. I'm personally against expanding the scope of semantic conventions, but I'd be ok if we have supplementary & non-normative aides for instrumentation authors if we feel it's necessary.

I want to push back a little bit on this point. Mostly I want to ask: if not here, where? We all agreed today that there should be a repository for this type of knowledge, but nobody seems to know where it should go. The options I can see are this repo, the specification repo, the website, or a new repo.

Between this repo and the spec repo, I think this one would be a much more obvious fit. The arguments not to include that guidance here applies to an even greater degree in the spec repo.

I think putting it in a new repo is off the table for most people, but I'll document the reasons here anyway. A new repo I think further splits the community and increases the number of places where instrumentation authors need to look in order to write good effective instrumentation. Especially after this OTEP, they would need to look here, in the spec, and in whatever guidance repo.

The same argument that it divides implementors attention also applies to the website to a lesser degree, which is targeted mostly towards end-users at the moment, not instrumentation authors. I could maybe buy the argument that this is documentation and should live on the website though.

Additionally, if we call the repository "Instrumentation" people may actually look for implementation, when in fact this is just a specification of sorts.

I'm open to a different name, but calling it "Semantic Conventions" seems to exclude the idea of instrumentation guidance in the future.

@jsuereth
Copy link
Contributor Author

I can accept most of that.

On instrumentation vs. semantic conventions

I just don't think we want to expand scope of semantic conventions that far right now. That' worth a discussion of its own, but well outside the scope of this PR. I'm personally against expanding the scope of semantic conventions, but I'd be ok if we have supplementary & non-normative aides for instrumentation authors if we feel it's necessary.

I want to push back a little bit on this point. Mostly I want to ask: if not here, where? We all agreed today that there should be a repository for this type of knowledge, but nobody seems to know where it should go. The options I can see are this repo, the specification repo, the website, or a new repo.

Between this repo and the spec repo, I think this one would be a much more obvious fit. The arguments not to include that guidance here applies to an even greater degree in the spec repo.

I think perhaps the nuance in what I'm saying didn't make it through.

  • I'm against normative instructions for instrumentation in the semantic convention repository. That's outside the scope.
  • I'm ok with non-normative guidelines and aides for how to instrument. In this, I think we're in alignment.

I think putting it in a new repo is off the table for most people, but I'll document the reasons here anyway. A new repo I think further splits the community and increases the number of places where instrumentation authors need to look in order to write good effective instrumentation. Especially after this OTEP, they would need to look here, in the spec, and in whatever guidance repo.

+1. I agree that would make it harder.

Additionally, if we call the repository "Instrumentation" people may actually look for implementation, when in fact this is just a specification of sorts.

I'm open to a different name, but calling it "Semantic Conventions" seems to exclude the idea of instrumentation guidance in the future.

I don't really want to bikeshed on a new name. I think Semantic Conventions fits, and it's ok to have (non-normative) guidance on instrumentation in this repository.

Where I think we need more discussion is on where different non-normative "guidelines" belong overall. For example, Metrics provides a lot of guidelines around how best to name metrics, units and dealing with fun scenarios like time-gaps, delta to cumulative conversions, etc. Which of these belongs in the specification and which belong in semantic conventions?

My rule of thumb proposal is "Guidance on how best to implement instrumentation that abides by semantic conventions" can be in non-normative locations in the semantic convention repo. All other guidelines and aides would remain in the specification. WDYT?

@Oberon00
Copy link
Member

Oberon00 commented Mar 22, 2023

I'm against normative instructions for instrumentation in the semantic convention repository. That's outside the scope.

Does this mean, they should be non-normative, or they need a different place, or they are entirely out of scope for OTel?

IMHO, formally non-normative but still prescriptive would be fine.

jsuereth and others added 7 commits May 3, 2023 08:29
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@carlosalberto
Copy link
Contributor

FYI @yurishkuro after some more discussion, we have decided to leave the 2.0 version change discussion out of this OTEP, leaving it as an open question here and discussing its merits after the split has happened and we are ready to release there.

@carlosalberto
Copy link
Contributor

Merging this as we have enough approvals and the feedback has been addressed (either by updating the content or by adding the discussion points to the open questions section, e.g. whether we should go 2.0 for the semantic conventions when this split happens).

Let's continue discussing the details once we start working on the actual changes.

@carlosalberto carlosalberto merged commit 976c939 into open-telemetry:main May 5, 2023
2 checks passed
pyohannes pushed a commit to pyohannes/oteps that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet