Initialization of global variables #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
jkwatson
reviewed
Dec 21, 2019
jkwatson
reviewed
Dec 21, 2019
jkwatson
reviewed
Dec 21, 2019
dyladan
reviewed
Dec 23, 2019
This was referenced Dec 23, 2019
yurishkuro
reviewed
Dec 23, 2019
yurishkuro
reviewed
Dec 23, 2019
yurishkuro
reviewed
Dec 23, 2019
| instances to become functional once the corresponding implementation | ||
| is initialized. The default instances returned by the global getters | ||
| for Tracer provider, Meter provider, and Propagators must "forward" to | ||
| the real SDK implementation once it is installed. |
safris
approved these changes
Dec 25, 2019
|
Note: a PR for Java which implements the changes I think would be required for this OTEP: open-telemetry/opentelemetry-java#724 |
lizthegrey
pushed a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Jan 2, 2020
* Global trace forwarding implementation according to open-telemetry/oteps#74
huikang
pushed a commit
to huikang/opentelemetry-go
that referenced
this pull request
Jan 3, 2020
* Global trace forwarding implementation according to open-telemetry/oteps#74
|
I've updated this OTEP stating that languages have an option to implement both SPI and explicit initialization, as long as it's consistent and satisfies the rules. |
|
The behavior described in this PR is implemented in OTel-Go. I suspect other languages will need the same approach to global SDK behavior, but with the work already done in OTel-Go, I see no need to keep this PR. |
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this pull request
Aug 26, 2022
* Global trace forwarding implementation according to open-telemetry/oteps#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #45, since the content has been largely rewritten.
This now refers to a prototype in Go: open-telemetry/opentelemetry-go#392