Skip to content

Commit

Permalink
exclude max int-valued metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
dashpole committed May 21, 2024
1 parent 66a9965 commit c527c4b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/runtime/go-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ This metric is [recommended][MetricRecommended].
<!-- semconv metric.go.memory.limit(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description | Stability |
| -------- | --------------- | ----------- | -------------- | --------- |
| `go.memory.limit` | UpDownCounter | `By` | Go runtime memory limit configured by the user, otherwise math.MaxInt64. [1] | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `go.memory.limit` | UpDownCounter | `By` | Go runtime memory limit configured by the user, if a limit exists. [1] | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

**[1]:** Computed from `/gc/gomemlimit:bytes`.
**[1]:** Computed from `/gc/gomemlimit:bytes`. This metric is excluded if the limit obtained from the Go runtime is math.MaxInt64.
<!-- endsemconv -->

<!-- semconv metric.go.memory.limit(full) -->
Expand Down
3 changes: 2 additions & 1 deletion model/metrics/go-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@ groups:
- id: metric.go.memory.limit
type: metric
metric_name: go.memory.limit
brief: "Go runtime memory limit configured by the user, otherwise math.MaxInt64."
brief: "Go runtime memory limit configured by the user, if a limit exists."
note: >
Computed from `/gc/gomemlimit:bytes`.
This metric is excluded if the limit obtained from the Go runtime is math.MaxInt64.
instrument: updowncounter
unit: "By"
stability: experimental
Expand Down

0 comments on commit c527c4b

Please sign in to comment.