Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to create semconv-system-approver #294

Closed
AlexanderWert opened this issue Aug 31, 2023 · 3 comments · Fixed by #309
Closed

Request to create semconv-system-approver #294

AlexanderWert opened this issue Aug 31, 2023 · 3 comments · Fixed by #309
Assignees

Comments

@AlexanderWert
Copy link
Member

I'd like to request creating a new approver group semconv-system-approver and add the following approvers to that group:

This group would be the code-owner for system-related semantic conventions including system-related resource (host, container, k8s, etc.) attributes as well as system metrics.

@mx-psi
Copy link
Member

mx-psi commented Sep 6, 2023

@arminru What should be the next steps for this?

@arminru
Copy link
Member

arminru commented Sep 8, 2023

I created https://github.com/orgs/open-telemetry/teams/semconv-system-approvers and added the initial members.

@kaiyan-sheng please follow the steps described here to join the OTel Github org so I can add you as well:
https://github.com/open-telemetry/community/blob/main/community-membership.md#member

@mx-psi The next steps would be to adapt the CODEOWNERS file in this repo here to add the new @open-telemetry/semconv-system-approvers group to the respective sub-folders/files.

@mx-psi
Copy link
Member

mx-psi commented Sep 11, 2023

Thanks! See #309 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants